knowsys / knowsys/nemo

Computing #sum panics when aggregating over non-numeric values

Open
#632 0 comments 0 reactions 1 assignee Claimed by @aannleax View on GitHub
bug
Dominant language
Rust
Stars
289
Forks
21
PR merge metrics
No merged PRs in 30d

Description

When using `#sum` over exclusively non-numeric values, nemo panics with the following error message:

```
thread 'main' panicked at nemo-physical/src/tabular/operations/aggregate.rs:308:25:
failed to compute aggregate result
```

This is because aggregates are currently implemented using the `TrieScan` interface, which does not allow for missing values.

Since the implementation of `TrieScanAggregate` is already complex enough, I would rather just rework how aggregates are computed using a technique similar to `RowScan`s.

This issue was first discussed here: #629.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.