knative / knative/test-infra

Flaky test reporter and retryer won't work well for duplicated repo names

Open
#2,107 3 comments 0 reactions 0 assignees View on GitHub
bug kind/good-first-issue lifecycle/frozen
Dominant language
Go
Stars
83
Forks
160
PR merge metrics
No merged PRs in 30d

Description

When flaky test reporter generate report files, the file name will only contain the repo name, see https://github.com/knative/test-infra/blob/master/tools/flaky-test-reporter/jsonreport/jsonreport.go#L78, and flaky test retryer will only get the report with the repo name. This normally works well, but will have problems for sure if there are duplicated repo names under different orgs.

The fix would be also appending the org name in the name of the report artifact.

/bug

Contributor guide

Open the contributing guide

Research direction

Start in tools/flaky-test-reporter/jsonreport/jsonreport.go around line 78, then trace how the flaky test retryer selects report files. Ensure report artifacts and retryer lookup distinguish repositories with the same name under different organizations, and verify the reporter and retryer tests cover duplicated repo names.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.