knative / knative/serving

[multi-container] How should Revision[CPU|Memory]Request defaults apply to revisions with multiple containers

Open
#7,240 9 comments 0 reactions 1 assignee View on GitHub

@dprotaso is already working on this.

Since Mar 22, 2021.

area/API help wanted kind/spec lifecycle/frozen triage/accepted
Dominant language
Go
Stars
6.1k
Forks
1.2k
Avg merge
2d 7h
Merged PRs (30d)
2

Description

Does applying this default still make sense?

I'd think RevisionCPURequest & RevisionMemoryRequest would imply totals for all user containers combined?

Now the Pod's requests/limits are a multiple of the number of containers

Originally posted by @dprotaso in https://github.com/knative/serving/pull/7167

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.