knative / knative/serving

Encryption Cleanup: drop LegacyFakeDnsName in SANs

Open
#14,992 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
6.1k
Forks
1.2k
Avg merge
2d 7h
Merged PRs (30d)
2

Description

Description

In our certificates for the system-internal-tls feature, we are still using certificates.LegacyFakeDnsName for legacy reasons and to make trust work on ingress layers that do not support trusting multiple SANs (like in contour and gateway-api).

As soon as this is resolved, we need to clean that up and remove certificates.LegacyFakeDnsName

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the system-internal-tls certificate generation and every use of certificates.LegacyFakeDnsName, then investigate whether the Contour and Gateway API ingress trust limitation described here has been resolved. Once that dependency is confirmed, remove the legacy SAN usage and the LegacyFakeDnsName definition, and run the relevant certificate and TLS tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.