knative / knative/serving

Decode all CAs in secret for activator

Open
#13,877 0 comments 0 reactions 0 assignees View on GitHub
kind/feature triage/accepted
Dominant language
Go
Stars
6.1k
Forks
1.2k
Avg merge
2d 7h
Merged PRs (30d)
2

Description

As per https://github.com/knative/serving/pull/13854#discussion_r1164328392

Currently we decod only one CA in the top of the secret.

https://github.com/knative/serving/blob/018c7f81957bbe5d152d6a0b5569c12e2baab0bd/pkg/activator/certificate/cache.go#L96

It should be fine at this moment, but it should decode all CAs in the secret especially if we support BYO CA cert.

Contributor guide

Open the contributing guide

Research direction

Start in pkg/activator/certificate/cache.go at the linked line and review the existing secret CA decoding behavior, along with the referenced pull-request discussion. Update the handling so all CAs in the secret are decoded, including BYO CA certificates, and verify the relevant activator certificate behavior with the repository's tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.