knative / knative/serving

Terminal API failures when creating child resources don't trigger Ready=False

Open
#13,131 1 comment 0 reactions 0 assignees View on GitHub
triage/accepted
Dominant language
Go
Stars
6.1k
Forks
1.2k
Avg merge
2d 7h
Merged PRs (30d)
2

Description

From https://github.com/knative/serving/issues/13053

A misplaced annotation prevented the SKS from being created since it failed validation. But this didn't cause the PodAutoscaler to flip to Ready=False.

There are probably other classes of this error throughout the codebase especially since any mutating webhook could inject a failure at any point. ie. rejecting deployment creation because of some security policy.

Note: terminal implies the creation/update requests will never succeed

Contributor guide

Open the contributing guide

Research direction

Start by reading the linked context in issue 13053 and tracing how SKS creation failures are reported to the PodAutoscaler. Check the paths that handle child-resource creation and mutating webhook rejection, then verify that terminal failures cause Ready=False without retrying indefinitely. Done means the behavior is covered for the described validation failure and comparable terminal creation or update errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend, infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.