knative / knative/serving

Determine rollout duration semantics when next revision fails

Open
#12,349 1 comment 0 reactions 0 assignees View on GitHub
triage/accepted
Dominant language
Go
Stars
6.1k
Forks
1.2k
Avg merge
2d 7h
Merged PRs (30d)
2

Description

> What if the new revision throws errors? Would the time based traffic shifting continue?

It seems like we should potentially document/clarify/fix the semantics of the rollout duration when the next revision fails. But I'm tempted to make separate issue and close this out.

So far it seems this issue was opened just to track the flagger integration. But I'd rather folks comment upstream to signal you want Knative support.

From: https://github.com/knative/serving/issues/2721#issuecomment-958609435

Contributor guide

Open the contributing guide

Research direction

No file or test is named. Start by reading the rollout-duration and failed-next-revision behavior in Knative Serving, then review the referenced upstream issue and its Flagger context. Done means the project’s semantics are decided and either documented clearly or tracked as a specific fix with verifiable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
backend
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.