knative / knative/serving

Support https option on upgrade test

Open
#11,535 1 comment 0 reactions 0 assignees View on GitHub
area/networking area/test-and-release kind/feature triage/accepted
Dominant language
Go
Stars
6.1k
Forks
1.2k
Avg merge
2d 7h
Merged PRs (30d)
2

Description

## In what area(s)?

/area networking
/area test-and-release

## Describe the feature

Current upgrade test `test/e2e-upgrade-tests.sh` does not spport `https` option.

As far as tested with the following changes:

https://github.com/knative/serving/pull/11529/commits/1a2dcb6cc6b8d5ab2958d579468f45a22d70a9b8
https://github.com/knative/serving/pull/11529/commits/266ef370e5f94c3a64f5ffa65ea79780b143e23e

The test works in general but SLO does not meet 100% as [test log](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_serving/11529/pull-knative-serving-upgrade-tests/1404774707986698240)

```
probe.go:59: CheckSLO() error SLI for "TestServingUpgrades/VerifyContinualTests/ProbeTest" = 0.412942, wanted >= 1.000000
```

Contributor guide

Open the contributing guide

Research direction

Start with test/e2e-upgrade-tests.sh and compare its current handling with the two referenced commits. Review the linked test log to understand why the HTTPS-enabled upgrade test misses the 100% SLO target. Done means the upgrade test supports the HTTPS option and the relevant SLO check passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
networking, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.