knative / knative/pkg

Consider changing sharedmain behaviour about panic'ing when a config map is missing

Open
#3,195 5 comments 0 reactions 0 assignees View on GitHub
good first issue triage/accepted
Dominant language
Go
Stars
276
Forks
343
Avg merge
1d 1h
Merged PRs (30d)
1

Description

That's fine. I'm slighly worried about "halt and catch fire" as a behavior when a configmap we ship has been removed. The idea of shipping them has mostly been about documentation, not about requiring them to have specific contents (or even be present) for things to function.

_Originally posted by @evankanderson in https://github.com/knative/pkg/pull/3190#discussion_r2169001114_

Contributor guide

Open the contributing guide

Research direction

Start by locating the sharedmain behavior that panics when a shipped config map is missing, then read the surrounding config-map handling and related tests. Define the expected behavior for absent config maps and verify that shipped config maps remain documentation rather than required runtime inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.