knative / knative/pkg

Consider putting the admission review on the webhook context

Open
#2,656 14 comments 0 reactions 2 assignees View on GitHub

@dprotaso is already working on this.

Since May 29, 2026.

good first issue help wanted lifecycle/frozen
Dominant language
Go
Stars
276
Forks
344
Avg merge
1d 1h
Merged PRs (30d)
1

Description

    > The use case is that I need to parse again the AdmissionRequest from Request.Body to perform further checks in the validating/mutating phase.

Would it make more sense for the AdmissionRequest go object to be on the context - instead of having the raw request body and parsing it again yourself?

Originally posted by @dprotaso in https://github.com/knative/pkg/issues/2583#issuecomment-1331507771

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.