knative / knative/pkg

`WantDeleteCollections` was never implemented in `TableTest`

Open
#2,455 5 comments 0 reactions 0 assignees View on GitHub
area/API area/networking area/test-and-release kind/bug kind/good-first-issue lifecycle/frozen
Dominant language
Go
Stars
276
Forks
343
Avg merge
1d 1h
Merged PRs (30d)
1

Description

/area API
/area networking
/area test-and-release
/kind bug
/kind good-first-issue

## Expected Behavior

A `TableTest` with `WantDeleteCollections` verifies things work!

## Actual Behavior

It silently ignores `DeleteCollection` calls.

See also: https://github.com/knative/pkg/blob/d2cdc682d97482be4d71bfd34f2ab000f7070dd4/reconciler/testing/table.go#L75

Contributor guide

Open the contributing guide

Research direction

Start in reconciler/testing/table.go around line 75, as linked in the issue, and inspect how TableTest handles the WantDeleteCollections expectation. Trace the existing TableTest behavior and tests for collection operations, then ensure DeleteCollection calls are verified rather than ignored and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.