knative / knative/pkg

[flakey] webhook.TestAdmissionInvalidResponseForResource

Open
#2,432 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
276
Forks
344
Avg merge
1d 1h
Merged PRs (30d)
1

Description

=== RUN   TestAdmissionInvalidResponseForResource
[2366](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2366)
    logger.go:130: 2022-02-15T16:23:56.397Z	INFO	webhook/webhook.go:200	Informers have been synced, unblocking admission webhooks.
[2367](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2367)
2022/02/15 16:23:56 http: TLS handshake error from 127.0.0.1:50900: EOF
[2368](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2368)
    logger.go:130: 2022-02-15T16:23:56.551Z	ERROR	webhook/webhook.go:150	failed to fetch secret	{"error": "secret \"webhook-certs\" not found"}
[2369](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2369)
2022/02/15 16:23:56 http: TLS handshake error from 127.0.0.1:50902: tls: no certificates configured
[2370](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2370)
    admission_integration_test.go:403: Failed to receive response Get "https://0.0.0.0:42363/booger": remote error: tls: unrecognized name
[2371](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2371)
    logger.go:130: 2022-02-15T16:23:56.552Z	INFO	webhook/webhook.go:242	Starting to fail readiness probes...
[2372](https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_pkg/2425/pull-knative-pkg-unit-tests/1493620921280237568#1:build-log.txt%3A2372)
--- FAIL: TestAdmissionInvalidResponseForResource (0.26s)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TestAdmissionInvalidResponseForResource in admission_integration_test.go, especially the failure at line 403, and review the related webhook behavior in webhook/webhook.go. Reproduce the test failure and trace the TLS or secret-fetch errors; done means the test no longer flakes and passes reliably.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.