Remove KProbe logic from Drainer
Open
Nobody has claimed this yet.
area/networking
lifecycle/frozen
- Dominant language
- Go
- Stars
- 276
- Forks
- 344
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
/area networking
Follow up from Serving PR: https://github.com/knative/serving/pull/12033
- comment about KProbe logic in drainer being a duplicate functionality https://github.com/knative/serving/pull/12033#pullrequestreview-779938231
A related concern (but I don't think it should block this PR) is why the drainer has KProbe logic in it
https://github.com/knative/pkg/blob/main/network/handlers/drain.go#L157
I think that makes the network.NewProbeHandler a noop in this instance
https://github.com/knative/networking/blob/main/pkg/probe_handler.go#L37
- Other comment about same https://github.com/knative/serving/pull/12033#discussion_r735640426
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with network/handlers/drain.go at the referenced KProbe logic around line 157, then compare it with networking/pkg/probe_handler.go around line 37 and the linked Serving PR comments. Confirm which behavior is duplicated; done means the Drainer no longer contains the redundant KProbe logic without making the probe handler a no-op.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100