knative / knative/pkg

Class-based reconcilers can't be hosted in one binary with HA

Open
#2,109 2 comments 0 reactions 0 assignees View on GitHub
kind/bug lifecycle/frozen
Dominant language
Go
Stars
276
Forks
343
Avg merge
1d 1h
Merged PRs (30d)
1

Description

/kind bug

## Expected Behavior

I can host as many class-based controllers (for example: Ingress reconcilers) as I want in a binary, as long as the classes don't clash.

## Actual Behavior

They try to get the same lease and thus only one really works. This is quite similar to #1979.

## Steps to Reproduce the Problem

1. Create a binary that launches two Ingress reconcilers
2. Launch it and see how it competes for the lease.

## Additional Info

This is quite similar to #1979.

I guess the simplest way of fixing it is adding the class filter to the lease name.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the problem with two Ingress reconcilers in one binary and trace how each lease name is derived. Done means class-based reconcilers with different classes no longer compete for the same lease while running with HA.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.