knative / knative/pkg

webhook binding labels should be more finely grained

Open
#1,233 2 comments 0 reactions 0 assignees View on GitHub
area/API kind/feature lifecycle/frozen
Dominant language
Go
Stars
276
Forks
343
Avg merge
1d 1h
Merged PRs (30d)
1

Description

As @mattmoor described in #1208, we face a growing number of bindings.

> I'd left a TODO about adding per-Binding opt-in/out, so I wonder if we're going to go this route whether we should be doing so using a fine-grained annotation like that instead.. WDYT?

> Could be something like: {gvr}/binding: enabled? so:

```
sinkbindings.sources.knative.dev/binding: "enabled"
githubbindings.bindings.knative.dev/binding: "enabled"
vspherebindings.sources.tanzu.vmware.com: "enabled"
...
```
the webhook should implement this

Contributor guide

Open the contributing guide

Research direction

Start by locating the webhook binding logic and reviewing the annotation examples in this issue. Clarify the per-binding opt-in/out behavior and annotation format, then verify that the webhook handles the listed binding groups accordingly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.