psbinding webhook leaks inclusion/exclusion lables
Open
Nobody has claimed this yet.
area/API
kind/bug
kind/cleanup
lifecycle/frozen
- Dominant language
- Go
- Stars
- 276
- Forks
- 344
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
Expected Behavior
Once all podspecable bindings are removed from a namespace, the webhook should remove the label to ensure we don't pollute the namespace
Actual Behavior
The psbinding reconcile leaves a bindings.knative.dev/include: true label on namespaces it touches
Steps to Reproduce the Problem
- create a compliant knative source & sink
- `k get ns -oyaml | grep
Additional Info
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with a compliant Knative source and sink, then inspect the psbinding reconcile path responsible for namespace labels. Verify that after all podspecable bindings are removed from a namespace, the bindings.knative.dev/include: true label is also removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100