knative / knative/pkg

[webhook] Don't depend on system.Namespace

Open
#1,159 5 comments 0 reactions 0 assignees View on GitHub
lifecycle/frozen
Dominant language
Go
Stars
276
Forks
343
Avg merge
1d 1h
Merged PRs (30d)
1

Description

> I am super unthrilled to have this code depend on system.Namespace, but that should work :)
But also we can only use it for the system namespace, I can't limit it to any other (which we might want at some point, maybe).

_Originally posted by @vagababov in https://github.com/knative/pkg/pull/1158_

Contributor guide

Open the contributing guide

Research direction

Start by locating the webhook code that depends on system.Namespace and reviewing how that dependency limits namespaces beyond the system namespace. Determine the intended replacement from the surrounding webhook implementation and discussion; done means the webhook no longer has this dependency while preserving its current behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.