[webhook] logger in context should be annotated with webhook type
Open
Nobody has claimed this yet.
kind/cleanup
lifecycle/frozen
- Dominant language
- Go
- Stars
- 276
- Forks
- 344
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 1
Description
Issue
When debugging some defaulting webhooks instrumenting SetDefaults on some types had the side-effect of logging invocations from the conversion webhook.
It was not obvious which webhook was doing the invocation of SetDefaults when looking at the logs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the defaulting webhook logging around SetDefaults and the conversion webhook invocation. Identify where the logger context is created, then verify that resulting logs distinguish the webhook type involved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100