knative / knative/operator

Services not using correct image for queue-proxy sidecar

Open
#2,313 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug lifecycle/stale
Dominant language
Go
Stars
226
Forks
117
Avg merge
12h 40m
Merged PRs (30d)
12

Description

Describe the bug

The configuration for overriding the image used by the queue-proxy sidecar is not working in my environment.

I am following the documentation to control the images used for Knative serving: https://knative.dev/docs/install/operator/configuring-serving-cr/#download-images-individually-without-secrets

Here is a sanitized version of my KnativeServing resource manifest

apiVersion: operator.knative.dev/v1beta1
kind: KnativeServing
metadata:
  name: knative-serving
  namespace: knative-serving
spec:
  registry:
    imagePullSecrets:
    - name: my-secret
    override:
      3scale-kourier-gateway/kourier-gateway: registry.my-org.com/knative-serving-kourier-gateway:1.35.3
      activator: registry.my-org.com/knative-serving-activator:1.22.0
      autoscaler: registry.my-org.com/knative-serving-autoscaler:1.22.0
      autoscaler-hpa: registry.my-org.com/knative-serving-autoscaler-hpa:1.22.0
      controller: registry.my-org.com/knative-serving-controller:1.22.0
      net-kourier-controller/controller: registry.my-org.com/knative-serving-kourier-controller:1.22.0
      queue-proxy: registry.my-org.com/knative-serving-queue:1.22.0
      webhook: registry.my-org.com/knative-serving-webhook:1.22.0
  version: 1.22.0

The services continue to use the default image for the queue-proxy container. My cluster's config-deployment Config Map has the default image specified in it explicitly:

apiVersion: v1
kind: ConfigMap
metadata:
  name: config-deployment
  namespace: knative-serving
data:
  queue-sidecar-image: gcr.io/knative-releases/knative.dev/serving/cmd/queue@sha256:371c23206b7bd924474b07e51435198579133eb98fba27a5cb3db9e6ba63b06b

Expected behavior

My expectation is that this would configure the Services to use my specified image for the queue-proxy container.

To Reproduce

  1. Install Knative Operator v1.22.1
  2. Create a KnativeServing resource with the queue-proxy image overridden
  3. Observe Service deployments not using the specified image for the queue-proxy container

Knative release version

Knative Operator 1.22.1 with Knative Serving 1.22.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with Knative Operator 1.22.1 and Knative Serving 1.22.0 using the documented KnativeServing manifest and inspect the resulting Services and config-deployment ConfigMap. Trace how the spec.registry.override entry for queue-proxy is handled and verify that completed Services use the specified queue image rather than the default queue-sidecar-image.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.