knative / knative/hack

We need to always delete the kind cluster if we create kind cluster with Prow jobs

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
26
Forks
70
PR merge metrics
No merged PRs in 30d

Description

Currently when we run test flows with `kind`, we run `kubetest2 kind --up --down` which will also delete the kind cluster after the test flow finishes in the normal way. But if the Prow job is interrupted in the middle, the cluster will not be properly deleted thus will be causing memory leakage, as described in https://github.com/kubernetes-sigs/kind/issues/303#issuecomment-521384993

We should add a trap command to make sure the cluster can still be cleaned up even when the Prow job is interrupted.

Contributor guide

Open the contributing guide

Research direction

Start by locating the Prow test-flow entry point that runs `kubetest2 kind --up --down`, then read how the normal cleanup is performed. Check the referenced kind interruption behavior and add a cleanup trap at the appropriate script boundary. Done means an interrupted Prow job still deletes the kind cluster, while normal test flows continue to clean up.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.