knative / knative/func

Remote Git-based deploy doesn't forward CLI overrides like `--image-pull-secret` to the in-cluster `func deploy`

Open
#3,768 3 comments 0 reactions 1 assignee View on GitHub

@Ankitsinghsisodya is already working on this.

Since May 17, 2026.

Dominant language
Go
Stars
365
Forks
223
Avg merge
2d 3h
Merged PRs (30d)
25

Description

Problem

For remote deploys that use the Git-based pipeline (a Git URL is configured), CLI flags like --image-pull-secret, --service-account, and --deployer do not reach the on-cluster func deploy step. Source is cloned from the remote Git repo on-cluster, so func.yaml in that path comes from whatever is committed in the repo — not from local disk, and not from the in-memory Function struct on the user's machine.

This is the Git-path equivalent of the bug PR #3663 fixed for the PVC-upload path. #3663 worked by persisting f to local func.yaml before invoking the pipeline, so the on-cluster step would read the updated config from the PVC. That mechanism doesn't help the Git path at all — local func.yaml is never uploaded.

Suggested approach (per @Ankitsinghsisodya)

The func-deploy task step runs func deploy inside the cluster. Forward the in-memory CLI overrides (--image-pull-secret, --service-account, --deployer, etc.) as discrete Tekton params on the pipeline run, and have the task template conditionally append them as flags to the in-cluster func deploy command.

Related

  • Surfaced in discussion on #3679 (which is scoped to the working-tree-dirty side-effect of #3663 on the PVC path).
  • #3663 — original fix for the PVC-path version of this bug.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.