knative / knative/eventing

Refactor observability setup in heartbeats/event_display

Open
#8,643 4 comments 0 reactions 1 assignee Claimed by @Arpit529Srivastava View on GitHub
triage/accepted
Dominant language
Go
Stars
1.6k
Forks
631
Avg merge
2d 1h
Merged PRs (30d)
6

Description

Given the similarities in the two sets of code, I wonder whether extracting them into a common method would be helpful, possibly with a signature like:

```
// SetUpObservability configures global otel meter and tracing providers, returning a
// cleanup function to be called on shutdown, and an error.
SetUpObservability(context.Context) (func(), error)
```

_Originally posted by @evankanderson in https://github.com/knative/eventing/pull/8640#discussion_r2214490866_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.