knative / knative/eventing

RequestReply: Create InitContainer

Open
#8,320 6 comments 0 reactions 1 assignee View on GitHub

@chaliuu is already working on this.

Since Nov 13, 2024.

kind/feature-request triage/accepted
Dominant language
Go
Stars
1.6k
Forks
631
Avg merge
3d 13h
Merged PRs (30d)
6

Description

Problem
Since the RequestReply resource needs a trigger to every pod, rather than to the deployment as a whole, we need to create an InitContainer which creates the trigger to the current pod. The trigger should look like:

apiVersion: eventing.knative.dev/v1
kind: Trigger
metadata:
  name: <generated name>
  namespace: <pod namespace>
spec:
  brokerRef: <brokerRef from the RequestReply resource>
  subscriber: <the RequestReply deployment>
  triggers:
    - cesql: "EXISTS <the name of the replyid for the RequestReply resource> AND KN_VERIFY_CORRELATION_ID(<the name of the replyid for the RequestReply resource>, <the secret names for the resource listed out>)"

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.