knative / knative/eventing

SinkBinding eliminates all volumes on Deployment subject

Open
#8,261 4 comments 0 reactions 0 assignees View on GitHub
kind/bug triage/accepted
Dominant language
Go
Stars
1.6k
Forks
631
Avg merge
2d 1h
Merged PRs (30d)
6

Description

**Describe the bug**
Given the subject in a SinkBinding is an arbitrary Deployment that brings its own volumes/volumeMounts spec these get eliminated as soon as the SinkBinding has injected K_SINK envVars. As a result the initial volume/volumeMount information is lost on the Deployment.

**Expected behavior**
The SinkBinding should preserve existing volume/volumeMount specs on the Deployment subject.

**To Reproduce**
* Create a Deployment with a custom volume/volumeMount
* Create a SinkBinding resource with the given Deployment as a subject
* See the existing volume/volumeMount disappear from the Deployment spec as soon as the SinkBinding envVar injection is done

**Knative release version**
v1.14.0

**Additional context**
used kubectl apply -f to create both Deployement and SinkBinding. Tested on local Kind cluster.

Contributor guide

Open the contributing guide

Research direction

Search the repository for SinkBinding and the K_SINK environment-variable injection path, then reproduce the issue with a Deployment containing a custom volume and volumeMount. Done means the existing volume and volumeMount specifications remain after the SinkBinding injection.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.