Merge TLS and OIDC e2e tests
Open
Nobody has claimed this yet.
help wanted
kind/cleanup
triage/accepted
- Dominant language
- Go
- Stars
- 1.6k
- Forks
- 631
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 6
Description
Currently the TLS and OIDC e2e tests are mostly redundant and test the same (e.g. both have test to test the reply & DLS). Mostly the only difference is, that the OIDC tests configure an audience.
Therefor we should check, which OIDC and TLS tests can be merged and merge both "suites" together.
Hint:
- Some tests still might be only relevant for TLS or OIDC (e.g. TestBrokerSupportsOIDC which tests only for OIDC compliance)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked TestBrokerSupportsOIDC in test/rekt/broker_test.go, then locate the TLS and OIDC end-to-end suites and compare their reply and DLS coverage. Merge tests that exercise the same behavior while retaining OIDC-only checks such as broker compliance; done means the redundant suites are consolidated without losing protocol-specific coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100