knative / knative/client

Refactor autoscaling parameters

Open
#816 16 comments 0 reactions 0 assignees View on GitHub
kind/feature kind/refactor triage/accepted
Dominant language
Go
Stars
387
Forks
274
Avg merge
1d 6h
Merged PRs (30d)
8

Description

Since we have collected all concurrency related options with the option prefix `--concurrency-` and also list them together in `kn service describe`, the autoscale window parameter should be also in this group. So either move everything to `--concurrency-` or, move everything (limit, target, utilization, window) to `--autoscale`.

I'm not sure in which direction to go, moving to `--concurrency` is easier as most of the options are already `--concurrency` prefixed, on the other "concurrency" is quite tedious to type, so maybe 'autoscale-' is a better prefix? But we might even consider a total different prefix as well?

Contributor guide

Open the contributing guide

Research direction

Start by locating the CLI definitions for the concurrency-related options and the code that lists them in `kn service describe`. Compare the existing `--concurrency-` and autoscale window handling, then resolve which consistent prefix should cover limit, target, utilization, and window. Done means the options use the chosen naming scheme and are listed consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
cli
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.