knative / knative/client

dont create new revision if image is unchanged

Open
#398 18 comments 0 reactions 0 assignees View on GitHub
kind/bug triage/accepted
Dominant language
Go
Stars
387
Forks
274
Avg merge
1d 6h
Merged PRs (30d)
8

Description

## In what area(s)?
Classifications:
/kind bug

## What version of Knative Client?
Version: v20190828-local-f53ebd8
Build Date: 2019-08-28 09:06:01
Git Revision: f53ebd8-dirty
Dependencies:
- serving: v0.6.0
- eventing: v0.8.0

## What version of Knative Serving running on your cluster?

0.6.x

## Expected Behavior
When I run the command `kn service update XXX --image gcr.io/project/XXX` I would like that the latest version of my container is deployed. The latest version must be automatically checked against the GCR full checksum and not with the short name in the command.

## Actual Behavior
Nothing is performed because the kn tool check only the name of the image and not the tag of the latest version in the GCR.

## Steps to Reproduce the Problem

* Run `kn service create XXX --image gcr.io/project/XXX`
* Deploy a new version in GCR
* Run `kn service update XXX --image gcr.io/project/XXX`
-> No new revision created. But the container are really different.

## Workaround
I alternate the command

* `kn service update XXX --image gcr.io/project/XXX`
* `kn service update XXX --image gcr.io/project/XXX:latest`

Contributor guide

Open the contributing guide

Research direction

Start at the `kn service update` command and trace how the client compares the requested image with the deployed image, then reproduce the case using the listed create, registry deployment, and update steps. Done means updating the same short image name after a new GCR image is available creates a new Knative Serving revision.

Written by the indexing model from the issue text.

Assessment

Tech stack
gcp, go, kubernetes
Domain
cli, cloud
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.