Remove the additional explicit wait "hack" in progress bar
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 388
- Forks
- 274
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 8
Description
The additional explicit wait "hack" in the progress bar should be removed. If your UI has a lot of progress bars, this wait will be visible.
But, I don't see a way, with the current API of bubbles' progress, to achieve it otherwise...
Without the wait, we get UI with progress bars that are never 100% completed. See example: https://github.com/knative/client-pkg/pull/162#issuecomment-2013176150
Originally posted by @cardil in https://github.com/knative/client-pkg/pull/162#discussion_r1535599192
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at pkg/output/tui/progress.go, lines 188-193, and review the current progress-bar handling alongside the linked bubbles progress API. Remove the additional explicit wait without leaving progress bars visibly incomplete; verify the behavior with multiple progress bars.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100