knative / knative/client

Introduce --https flag which will add option to run all e2e tests with different http and https settings

Open
#1,520 9 comments 2 reactions 1 assignee Claimed by @gouthamhusky View on GitHub
good first issue kind/feature triage/accepted
Dominant language
Go
Stars
387
Forks
274
Avg merge
1d 6h
Merged PRs (30d)
8

Description

### Feature request

Please introduce `--https` flag, similar to one in knative/serving: https://github.com/knative/serving/pull/5157

### Use case

The flag will add option to run all e2e tests with different http and https settings.
Currently, [TestDomain](https://github.com/knative/client/blob/release-0.25/test/e2e/domain_mapping_test.go#L31) test expects the first service to be available at http, and the second at https, but this may not be the case if "defaultExternalScheme" is set to https.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.