knative-extensions / knative-extensions/knobots
update-deps bot does not send PR for only module diff
- Dominant language
- Shell
- Stars
- 8
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
The script excludes diff in `go.mod`, `go.sum` and `modules.txt`:
https://github.com/knative-sandbox/knobots/blob/05c5158e8da094a33d708fd7c7d504faed62ca3b/actions/update-deps/entrypoint.sh#L59-L70
so update-deps bot does not create the PR even when deps have diff - e.g. https://github.com/knative-sandbox/knobots/runs/2523678545?check_suite_focus=true did not create PR (please check in `Apply work`)
```
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)
modified: go.mod
modified: go.sum
modified: vendor/modules.txt
```
This is no problem in general as it is just a module name change. But it causes an error in `Verify Deps and Codegen` actions.
(e.g.) https://github.com/knative-sandbox/net-kourier/pull/509/checks?check_run_id=2515042767
Now I am wondering if update-deps bot should create the PR or `.github/workflows/knative-verify.yaml` should exclude the module name diff.
Contributor guide
Research direction
Start with actions/update-deps/entrypoint.sh lines 59-70 and reproduce the Apply work behavior from the linked workflow run. Then inspect .github/workflows/knative-verify.yaml to compare handling of module-only changes. Done means the chosen behavior is implemented and the relevant verification workflow no longer fails for this dependency diff.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, shell
- Domain
- ci-cd, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100