knative-extensions / knative-extensions/eventing-github

Make githubsource's SecretToken optional

Open
#36 6 comments 0 reactions 0 assignees View on GitHub
kind/feature-request triage/accepted
Dominant language
Go
Stars
21
Forks
37
Avg merge
15m
Merged PRs (30d)
5

Description

From https://github.com/knative/eventing-contrib/issues/297

Right now SecretToken appears to be required:
https://github.com/knative/eventing-sources/blob/master/pkg/apis/sources/v1alpha1/githubsource_types.go#L66

I think it would be nice if it were made optional, and if not provided then the system just created something to use (like a UUID). This value has no meaning outside of this subscription so I don't need the requirement to force the user to specify it. However, if someone does want to do so they can.

Contributor guide

Open the contributing guide

Research direction

Start with pkg/apis/sources/v1alpha1/githubsource_types.go at the referenced SecretToken field, then trace how that value is consumed when a GitHubSource is created. Confirm the expected behavior for an omitted token and update the relevant implementation and validation coverage so both omitted and explicitly supplied tokens work.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.