klen / klen/graphite-beacon

time_window priority in alert.py

Open
#97 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
450
Forks
117
PR merge metrics
No merged PRs in 30d

Description

self.time_window 's value should be `interval_to_graphite(options.get('time_window', self.reactor.options.get('time_window', self.interval)))` in `alert.py`, or the time_window option is useless in the configuration's main block

Contributor guide

No contributing guide indexed for this repository

Research direction

Open alert.py and inspect how self.time_window is assigned, especially the fallback to reactor options and the interval value. Update the handling so the main configuration block's time_window is honored, then verify that the resulting value is passed through interval_to_graphite as described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
observability-sre
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.