klei / klei/gulp-inject

Respect gulp --silent?

Open
#152 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
807
Forks
90
PR merge metrics
No merged PRs in 30d

Description

Hi, would it be possible to have the default `quiet` option based on the `--silent` flag of gulp's cli?

According to [this comment](https://github.com/gulpjs/gulp/issues/499#issuecomment-93824634) the setting can be found by doing:

```
const argv = require('minimist')(process.argv.slice(2));
const isSilent = !!argv.silent;
```

then the change could be as simple as replacing

```
opt.quiet = bool(opt, 'quiet', false);
```

by

```
opt.quiet = bool(opt, 'quiet', isSilent);
```

If that sounds reasonable I'll add some tests, try it out and submit a pull request when I have time.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the option handling that currently uses `opt.quiet = bool(opt, 'quiet', false)` and review how gulp CLI arguments are available through `process.argv`. Add tests as proposed in the issue, then verify that `--silent` supplies the default quiet value while an explicit quiet option still behaves correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.