klaudiosinani / klaudiosinani/taskbook

Adding package-lock.json to repository

Open
#205 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9.3k
Forks
393
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
`package-lock.json` is missing from the repo, making it hard to package.

**To Reproduce**
`npm install` -> not generating `package-lock.json` (cf [.npmrc](https://github.com/klaudiosinani/taskbook/blob/master/.npmrc))

**Expected behavior**
`package-lock.json` should be included and committed in the repository to pin dependencies.

**Screenshots**
\-

**Technical Info (please complete the following information)**
- OS: `NixOS`
- Node.js Version: `v20.19.0`
- Taskbook Version: `0.3.0`

**Additional context**
Is there any reason we shouldn't commit `package-lock.json` to the repo ?
I'm trying to package this tool for https://github.com/NixOS/nixpkgs/issues/401580 and the absence of this file would require workarounds that could leave the package a few versions behind for a while in case of futur updates.

Contributor guide

Open the contributing guide

Research direction

The issue names .npmrc and the missing package-lock.json; start by checking the npm configuration and reproducing the npm install behavior. Done means package-lock.json is generated, committed, and pins the repository dependencies.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.