klarsys / klarsys/angular-material-icons

angular slick carousel does not respect viewBox of the ng-md-icon

Open
#71 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
553
Forks
148
PR merge metrics
No merged PRs in 30d

Description

Hi, we recently added angular-slick to our app, and all the custom SVG images (added with ngMdIconService.addShape and ngMdIconService.addViewBox) get rendered with viewBox svg attribute "0 0 24 24" while each image has viewBox set separately...

This may be not right place for the issue, but was looking for any suggestion/hint.

thank you.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue with angular-slick and a custom SVG registered through ngMdIconService.addShape and addViewBox. Inspect the rendered SVG viewBox values and determine whether the custom image's viewBox is preserved instead of being replaced by "0 0 24 24"; done means the custom viewBox renders correctly in the carousel.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.