kjaymiller / kjaymiller/render-engine-json

create a `modify` filter instead of the other parsers

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

The pattern for other suggested parsers like filter #4 and sort #3 are doing the same thing.

Using a function to modify the existing sequence... replacing data with a new sequence.

What's more challenging is that if you specify filter and sort. That hints to standard library sequence modifiers that behave differently.

Would it be better to just add a modify attribute that allows you to pass in the function of your choice to augment the data?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing suggested parsers described in issues #3 and #4, focusing on how filter and sort replace the current sequence. Determine whether a general modify attribute has a clear behavior and interface, including how combining modifiers should work. Done means the proposed design is agreed and its behavior is covered by appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.