kivy / kivy/python-for-android

Can/should we get rid of zope_interface's fix-init patch ?

Open
#3,083 2 comments 1 reaction 0 assignees View on GitHub
need-analysis Priority: Critical recipe
Dominant language
Python
Stars
8.9k
Forks
2k
Avg merge
12h 20m
Merged PRs (30d)
9

Description

https://github.com/kivy/python-for-android/blob/10c529261d1cb19f1873bcf31db4e3f88c099488/pythonforandroid/recipes/zope_interface/__init__.py#L22

If you check on Kivy Discord (or even in buildozer issues: kivy/buildozer#1601), there's a few mentions (including mine) of twisted failing to build because of `zope_interface`. It seems to work properly if we remove the fix-init patch, so maybe we're indeed in the future (cf comment in the recipe) and this errors out?

I opened this issue (instead of directly making a PR) to discuss the situation, in particular to check if people manage to properly build projects that use twisted without issues, in which case maybe the fix-init patch isn't the root cause.

Contributor guide

Open the contributing guide

Research direction

Start with pythonforandroid/recipes/zope_interface/__init__.py at the linked fix-init patch and review the related Buildozer issue kivy/buildozer#1601. Reproduce a Twisted build with and without the patch, then determine whether the patch is the cause and document the evidence needed to decide its removal.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.