kit-data-manager / kit-data-manager/wap-server
isIriDeleted check does not consider boolean value of the checked triple
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 4
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
Check for deleted flag only checks if there is a triple with the "deleted"-predicate, but it does not care if the value of the triple is set to true or false.
Might be quite safe at the moment because the value is only set to true, but would not work properly if at some point some 'undelete' operation takes place (via code, via sparql), setting the value to false.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/main/java/edu/kit/scc/dem/wapsrv/service/AbstractWapService.java around line 454 and inspect isIriDeleted. Trace how the deleted predicate's value is read and compare the behavior for true and false values. Done means the check distinguishes an actually deleted triple from one marked false.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100