kir-dev / kir-dev/sch-pincer

Internal Server Error because of CircleEntity.findByAlias

Open
#153 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
Kotlin
Stars
12
Forks
2
PR merge metrics
No merged PRs in 30d

Description

While browsing through the code, I've found this:

```Kotlin
@Transactional(readOnly = true)
open fun findByAlias(alias: String): CircleEntity {
return repo.findAllByAlias(alias)[0]
}
```

However, this might throw internal error: https://schpincer.sch.bme.hu/provider/langoscasdfh

I have not attempted to fix this, as much of the existing code could depend on it (haven't checked tho).

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with CircleEntity.findByAlias and repo.findAllByAlias, then reproduce the failure at /provider/langoscasdfh and inspect the existing callers before deciding how the missing alias should be handled. Done means an invalid alias no longer produces an internal server error while existing callers continue to behave correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin, spring-boot
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.