kir-dev / kir-dev/konyha

Refactor Procs in collection select at appliance_comments/_compact_form.html.haml

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
low priority ruby magic
Dominant language
Ruby
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

I was in a hurry so i used Procs, to create the contents of content select.

I think we could improve readability if we create a wrapper class (decorator) for ApplianceComment.categories.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with appliance_comments/_compact_form.html.haml and inspect how Procs build the content select from ApplianceComment.categories. Trace the existing category behavior before deciding how the wrapper class should be shaped; done means the select still behaves the same without the inline Procs.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.