kir-dev / kir-dev/collage-schedule-planner

Fix exceptions in all services

Open
#30 0 comments 0 reactions 0 assignees View on GitHub
backend invalid
Dominant language
TypeScript
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Quick fix: Now, every method throws a NotFoundException in all methods in the services. What we really want is to throw a 404 only when an object is really missing. In other situations (e.g. when connecting to db fails) getting not found could be misleading, therefore we should throw the corresponding exception or we wouldn't even need exception handling.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing all service methods that currently throw NotFoundException and trace how missing objects differ from database connection failures. Done means missing objects produce 404 responses while connection or other failures use the corresponding exception instead of being reported as not found.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.