kimmobrunfeldt / kimmobrunfeldt/spawn-default-shell

cmd.exe returns incorrect exit code

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
JavaScript
Stars
12
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Test case ["&& operator should work"](https://github.com/kimmobrunfeldt/spawn-default-shell/blob/dd4e15b4aa5026b2f1f49166c59eaf50705a128b/test/test-basic.js#L24-L31) is failing because cmd.exe doesn't return the exit code as expected.

This is what happens with cmd.exe /c:

screenshot 2016-09-30 21 17 35

It works in a cmd.exe session:

screenshot 2016-09-30 21 11 00

I don't know yet how to fix this issue. If anyone has ideas, please help.

Contributor guide

Open the contributing guide

Research direction

Start with test/test-basic.js lines 24-31 and reproduce the “&& operator should work” case on Windows. Investigate how cmd.exe /c reports the command's exit code compared with an interactive cmd.exe session. Done means the existing test passes with the expected exit code.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, shell
Domain
cli, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.