kimmobrunfeldt / kimmobrunfeldt/git-hours

--first-commit-add does not have any effect

Open
#65 3 comments 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
816
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Regardless if I put 0 or 1000 or nothing for first-commit-add it does not make any difference for the number of hours calculated.

```
$ git-hours
{
"X": {
"name": "X",
"hours": 233,
"commits": 1218
},
"total": {
"hours": 233,
"commits": 1218
}
}
$ git-hours --first-commit-add=0
{
"X": {
"name": "X",
"hours": 233,
"commits": 1218
},
"total": {
"hours": 233,
"commits": 1218
}
}
$ git-hours --first-commit-add=1000
{
"X": {
"name": "X",
"hours": 233,
"commits": 1218
},
"total": {
"hours": 233,
"commits": 1218
}
}
$ git-hours --version
1.5.0
```

It seems --max-commit-diff might have the same problem. Just installed git-hours with npm.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the git-hours CLI handling for --first-commit-add and --max-commit-diff, then reproduce the reported commands using version 1.5.0. Trace where these options enter the hours calculation; done means changing either value changes the calculated hours when appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.