killme2008 / killme2008/xmemcached

Spring dependency should be optional and not provided.

Open
#136 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
764
Forks
271
PR merge metrics
No merged PRs in 30d

Description

It appears that the only use of Spring is with the XMemcachedClientFactoryBean, so your core functionality does not require Spring be provided for the core functionality of the lib. In this case it's recommended that the dependency have a scope of "optional" instead of "provided".

I would be happy to issue a PR if you agree.

Thanks!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the Spring dependency declaration in the project build configuration and confirm how the library uses Spring. Change the dependency scope from "provided" to "optional", then verify that core functionality does not require Spring to be supplied.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.