khalyomede / khalyomede/command-builder

Use built-in PHP escape command function

Open
#1 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Versions

  • PHP: 8.0
  • Package: 0.2.1

Description

One folks at dev.to suggested to use shellescapeargs built-in function to escape arguments/option values instead of doing it manually.

Reference: https://dev.to/suckup_de/comment/1le40

Proposal

Use the built-in function instead of replacing characters to simplify escaping arguments and option values.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the command and argument escaping entry point in the PHP package and reviewing how option values are currently escaped. Check the existing test suite, if present, for escaping coverage; done means the built-in escape function is used for arguments and option values without breaking expected command strings.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
cli
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.