keymanapp / keymanapp/keyman

chore(common): builder should make sure that dep builds are not later called as child builds and vice-versa

Open
#9,744 0 comments 0 reactions 0 assignees View on GitHub
chore common/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

> Compare the later entries in both sections; they're nigh-identical.
>
> First set of calls: as a child script, from the top-level build.sh.
>
> Second set: as a _dependency_, from `web/src/test/manual`, which does not include `web/src/tools` as a viable child-project folder.

I reckon we should consider tweaking builder.inc.sh to handle the scenario of child vs dependency calls resulting in multiple calls.

_Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/issues/9743#issuecomment-1757122400_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.