keymanapp / keymanapp/keyman

chore(windows): deprecate usage of AssociatedKeyboard in .kvk

Open
#9,055 1 comment 0 reactions 1 assignee Assigned to @mcdurdin View on GitHub
chore epic-embed-osk-in-kmx windows/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

_Arising from https://github.com/keymanapp/keyman/pull/9054#discussion_r1236267701_

https://github.com/keymanapp/keyman/blob/164823a643d650c45f1c4cbd930d7cb2342aebc8/windows/src/engine/kmcomapi/processes/package/kpinstallpackage.pas#L277-L279

https://github.com/keymanapp/keyman/blob/164823a643d650c45f1c4cbd930d7cb2342aebc8/windows/src/engine/kmcomapi/processes/visualkeyboard/KPInstallVisualKeyboard.pas#L56-L57

These are the only two places where we use AssociatedKeyboard. The link should be unidirectional, not bidirectional, and AssociatedKeyboard should disappear altogether. (Even better option: embed the .kvk in the .kmx in the future... which we will probably do, albeit with a different file format.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.