keymanapp / keymanapp/keyman

chore(web): eliminate UI-module proto-minification artifacts

Open
#8,866 0 comments 0 reactions 0 assignees View on GitHub
web/
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

> TODO: one day let's eliminate this 🤣

_Originally posted by @mcdurdin in https://github.com/keymanapp/keyman/pull/8824#discussion_r1206186272_

The KMW UI modules were written in a relatively earlier period for JS, before good, strong minification tools were available. Accordingly, some of their source was written in a way to "help minification along", as it were - such as the section referenced below:

https://github.com/keymanapp/keyman/blob/733363a69def1e00c18c4c935805038f83b0f0b1/web/src/app/ui/kmwuitoggle.ts#L27-L29

There's no longer a need to help minification out in this fashion; the JS ecosystem has significantly matured since then. (Just in _other_ fashions that sometimes arise when down-compiling and bundling.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.