keymanapp / keymanapp/keyman

feat(android): acceptance of a correction mid-word should replace whole word

Open
#7,164 0 comments 0 reactions 0 assignees View on GitHub
android/ feat
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

**Is your feature request related to a problem? Please describe.**

From a team review of the Keyman for Android UX (https://github.com/keymanapp/keyman/issues/7161)

If you move the caret to the middle of a word, and then accept a suggestion, it should replace the whole word. Currently, it replaces left of the caret, but leaves the following text dangling, which is messy.

https://user-images.githubusercontent.com/4498365/187518950-6601fcb1-5911-423a-8297-efcf418a37eb.mp4

Per @jahorton: We tried this once: #4541
* Android was fully supported! But…
* iOS incompatible for now due to bugs on Apple’s end, unfortunately.
* Trying to do this for just one of the two is quite tricky.

@mcdurdin says:

> Trying to do this for just one of the two is quite tricky.

When instantiating Keyman Engine for Web, we could include a capabilities flag to tell it whether or not we support right-delete, and then bracket the fix from #4541 with that.

**Related issues**

* #4538

---

**Keyman for Windows/macOS/Linux/iPhone/iPad/Android:**
- Device: Samsung A90 5G
- OS: Android 12
- Keyman version: 15.0.269-stable

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.