keymanapp / keymanapp/keyman

bug(android/engine): KMManager doesn't check canAddKeyboard() and canRemoveKeyboard()

Open
#6,485 3 comments 0 reactions 0 assignees View on GitHub
android/ android/engine/ bug
Dominant language
Pascal
Stars
534
Forks
143
Avg merge
2d 10h
Merged PRs (30d)
113

Description

While writing up keymanapp/help.keyman.com#535, I noticed KMManager() isn't checking the static values for `canAddKeyboard()` and `canRemoveKeyboard()` when adding/removing keyboards.

They previously were tried to the visibility of the "+" button on the keyboard picker, but that got removed a few versions ago.

Current help documentation
https://help.keyman.com/developer/engine/android/14.0/KMManager/canAddNewKeyboard

> returns whether adding a new keyboard is enabled in the keyboard picker menu

Should the API be updated to be independent of the keyboard picker menu?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.